vismaytiwari commented on PR #16382:
URL: https://github.com/apache/lucene/pull/16382#issuecomment-4933880454
Pushed 9dc9ac5.
@uschindler — converted the `switch` in `toAutomaton` to the arrow form, and
dropped the `@SuppressWarnings("fallthrough")` while at it (the trailing-`\`
case is an explicit `else` now).
@amalatlas — added the `*?` × 5000 case you asked about, and it doesn't blow
up: the `*`s aren't consecutive so nothing collapses, but it still builds a
linearly-sized automaton (the repeated-`*` case this PR fixes was ~50M
transitions at that length). While there I also switched the collapse test to
compare automaton language equality via `AutomatonTestUtil.sameLanguage`
instead of only counting states/transitions, and added a variant that mixes an
escaped `\*` with literals and a `?`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
