vsop-479 commented on PR #16245:
URL: https://github.com/apache/lucene/pull/16245#issuecomment-4933824527
Thanks @mikemccand for the detailed review and all the suggestions. I pushed
updates addressing the comments.
> I'm worried about the added GC (allocating lots of small things,
briefly). They are short lived so maybe it's all in the noise. Have you run
luceneutil benchy to check?
Yes, this change does add allocations for simple64 decoding (but it no
longer uses `suffixLengthBytes` or `suffixLengthsReader`).
I will run luceneutil.
> Was there no existing reasonably-licensed open source Simple64 impl
already?
I looked around but did not find a mature, reasonably licensed Java Simple64
implementation(Just found `simple8b` implementations in `C++`/`Go`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
