uschindler commented on PR #16381: URL: https://github.com/apache/lucene/pull/16381#issuecomment-4933672466
The new code still has the problem of more complexity, but in general I like it more, as it can be used for more use-cases. I have to look closer into CharArrayMap. What happens if you add new elements later (the maps are modifiable)? Do you need to explicitely call the private method to make the cache? I did not found an automatic way in the code. It only builds it for CharArraySet when using the bulk constructor. Maybe a good thing would be to add a public "freeze()" method to CharArrayMap (and set), which improves its performance but makes it read-only at same time. Of course `add()` would need to throw UOE then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
