javanna commented on PR #16378: URL: https://github.com/apache/lucene/pull/16378#issuecomment-4913812206
Indeed, I could no longer reproduce any failures with this fix. You still have precision errors, but when you narrow the double sum down to a float at the end ((float) total), that tiny double-level discrepancy is almost always well below the float's rounding granularity, so both orderings round to the same float. In alternative, we could introduce some additional tolerance in the assertions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
