dweiss commented on PR #16323: URL: https://github.com/apache/lucene/pull/16323#issuecomment-4895764010
I agree with @neoremind 's assessment. It looks like an improvement but the extra memory allocation may kill any gains. It'd require some careful benchmarks (not just microbenchmarks but full-stack benchmarks) to see the impact. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
