salvatorecampagna commented on PR #16282: URL: https://github.com/apache/lucene/pull/16282#issuecomment-4787520049
> looks like a de-optimization with a benchmark that hides it I wrote the benchmark to compare against the generic loop, which seems to me like a fair baseline. The fast path didn't exist before and that is what the new benchmark is measuring: main without fast path versus pr with fast path. What scenario do you think it is hiding? Also, the previous comment was mine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
