venkateshwaracholan commented on code in PR #16252:
URL: https://github.com/apache/lucene/pull/16252#discussion_r3425237008
##########
lucene/core/src/java/org/apache/lucene/util/RoaringDocIdSet.java:
##########
@@ -454,6 +454,9 @@ private int firstDocFromNextBlock() throws IOException {
@Override
public void intoBitSet(int upTo, FixedBitSet bitSet, int offset) throws
IOException {
for (; ; ) {
+ if (sub == null) {
Review Comment:
@iprithv Thanks for the review. Using `doc == NO_MORE_DOCS` here is cleaner
and more consistent with the other `intoBitSet()` implementations. I've updated
the check and pushed the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
