gaobinlong commented on code in PR #15936:
URL: https://github.com/apache/lucene/pull/15936#discussion_r3379787561


##########
lucene/grouping/src/test/org/apache/lucene/search/grouping/TestBlockGrouping.java:
##########
@@ -58,7 +59,6 @@ public void testSimple() throws IOException {
     // score of the top document from the same query with no grouping
     TopDocs topDoc = searcher.search(topLevel, 1);
     assertEquals(topDoc.scoreDocs[0].score, tg.groups[0].scoreDocs()[0].score, 
0);
-    assertEquals(topDoc.scoreDocs[0].doc, tg.groups[0].scoreDocs()[0].doc);

Review Comment:
   We couldn't compare doc because in concurrent search mode, which doc with 
same highest score will in the final result is not guaranteed, the following 
tests already omitted this assert.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to