javanna commented on code in PR #16197:
URL: https://github.com/apache/lucene/pull/16197#discussion_r3371541057
##########
lucene/monitor/src/java/org/apache/lucene/monitor/ReadonlyQueryIndex.java:
##########
@@ -79,7 +81,21 @@ public long search(QueryBuilder queryBuilder, QueryCollector
matcher) throws IOE
queryBuilder.buildQuery(
termFilters.get(searcher.getIndexReader().getReaderCacheHelper().getKey()));
buildTime = System.nanoTime() - buildTime;
- searcher.search(query, collector);
+ searcher.search(
+ query,
+ new CollectorManager<LazyMonitorQueryCollector, Void>() {
Review Comment:
I personally think it's overkill to create a "single threaded collector
manager" to share for these two usages. It's easier to read when inline and
that saves us from creating a top level class for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
