javanna commented on code in PR #15660:
URL: https://github.com/apache/lucene/pull/15660#discussion_r3273824445
##########
lucene/sandbox/src/test/org/apache/lucene/sandbox/search/TestLargeNumHitsTopDocsCollector.java:
##########
@@ -90,94 +90,102 @@ public void testInvalidRequestedHitCount() {
}
}
- public void testTopDocs() throws IOException {
- IndexSearcher searcher = newSearcher(reader);
+ public void testTopDocs() {
LargeNumHitsTopDocsCollector largeCollector = new
LargeNumHitsTopDocsCollector(15);
- TopScoreDocCollectorManager regularCollectorManager =
- new TopScoreDocCollectorManager(15, Integer.MAX_VALUE);
-
- searcher.search(testQuery, largeCollector);
- TopDocs topDocs = searcher.search(testQuery, regularCollectorManager);
Review Comment:
thanks. I still don't get if it makes sense to verify the collectors without
ever doing any collection. Or am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
