gaobinlong commented on code in PR #15574:
URL: https://github.com/apache/lucene/pull/15574#discussion_r3265545819
##########
lucene/grouping/src/test/org/apache/lucene/search/grouping/TestGrouping.java:
##########
@@ -277,11 +279,13 @@ private FirstPassGroupingCollector<?>
createRandomFirstPassCollector(
String groupField, Sort groupSort, int topDocs) throws IOException {
if (random().nextBoolean()) {
ValueSource vs = new BytesRefFieldSource(groupField);
- return new FirstPassGroupingCollector<>(
- new ValueSourceGroupSelector(vs, new HashMap<>()), groupSort,
topDocs);
+ return new FirstPassGroupingCollectorManager<>(
+ () -> new ValueSourceGroupSelector(vs, new HashMap<>()),
groupSort, topDocs)
Review Comment:
The context can be shared, changed that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
