romseygeek commented on code in PR #16069:
URL: https://github.com/apache/lucene/pull/16069#discussion_r3247312469


##########
lucene/core/src/java/org/apache/lucene/search/MaxScoreBulkScorer.java:
##########
@@ -53,9 +53,19 @@ final class MaxScoreBulkScorer extends BulkScorer {
   private final DocAndFloatFeatureBuffer docAndScoreBuffer = new 
DocAndFloatFeatureBuffer();
   private final DocAndScoreAccBuffer docAndScoreAccBuffer;
 
+  private final boolean loadFilterIntoBitset;
+  private final FixedBitSet filterWindowMatches = new 
FixedBitSet(INNER_WINDOW_SIZE);
+  private final WindowBits windowBits = new WindowBits();

Review Comment:
   Do we need these extra two bitsets?  I think we should be able to just 
operate on filterWindowMatches and pass suitable offests around?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to