romseygeek commented on code in PR #16070: URL: https://github.com/apache/lucene/pull/16070#discussion_r3247287740
########## lucene/core/src/java/org/apache/lucene/search/SortedSkipperScorerSupplier.java: ########## @@ -0,0 +1,177 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.search; + +import java.io.IOException; +import java.io.UncheckedIOException; +import java.util.function.LongPredicate; +import org.apache.lucene.index.DocValuesSkipper; + +/** + * Constant-score supplier that uses a {@link DocValuesSkipper} to approximate the document interval + * matching a numeric or ordinal range when the leaf's primary {@link SortField} aligns with that + * field. + * + * <p>The skipper yields coarse min/max doc IDs that contain all matching documents. When the + * skipper interval at a boundary is not exact for the query range, {@link #nextDoc} scans forward + * from that doc to the first document whose value satisfies the appropriate comparison, producing a + * tight {@link DocIdSetIterator#range} iterator. + * + * @lucene.internal + */ +public abstract class SortedSkipperScorerSupplier extends ConstantScoreScorerSupplier { Review Comment: Let's make this package private? ########## lucene/core/src/java/org/apache/lucene/document/SortedSetDocValuesRangeQuery.java: ########## @@ -167,120 +168,39 @@ private ScorerSupplier getScorerSupplierFromDensePrimarySort( SortedDocValues singleton, SortedSetDocValues values, DocValuesSkipper skipper) { - final Sort indexSort = context.reader().getMetaData().sort(); - return new ConstantScoreScorerSupplier(score(), scoreMode, context.reader().maxDoc()) { - int skipperMinDocId = -1, skipperMaxDocId = -1; - long minOrd, maxOrd; - boolean skipperMinDocIdExact = false, skipperMaxDocIdExact = false; + final SortField sortField = context.reader().getMetaData().sort().getSort()[0]; Review Comment: This feels a bit dangerous - maybe we can change isDensePrimarySort() to return the primary SortField if it exists and then pass it to this method? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
