benwtrent commented on code in PR #16050: URL: https://github.com/apache/lucene/pull/16050#discussion_r3236528195
########## lucene/core/src/test/org/apache/lucene/search/TestSkipBlockRangeIteratorIntoBitSet.java: ########## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.search; + +import java.util.Random; +import org.apache.lucene.codecs.lucene104.Lucene104Codec; +import org.apache.lucene.document.Document; +import org.apache.lucene.document.NumericDocValuesField; +import org.apache.lucene.document.SortedNumericDocValuesField; +import org.apache.lucene.index.DirectoryReader; +import org.apache.lucene.index.IndexWriter; +import org.apache.lucene.index.IndexWriterConfig; +import org.apache.lucene.search.BooleanClause.Occur; +import org.apache.lucene.store.Directory; +import org.apache.lucene.store.MMapDirectory; +import org.apache.lucene.tests.util.LuceneTestCase; + +/** + * Verifies correctness of single-field and multi-field doc values range queries using {@link + * BatchDocValuesRangeIterator}. + * + * <p>Key behavioral notes: + * + * <ul> + * <li>Single-field range with a second clause (e.g., MatchAllDocsQuery): goes through {@code + * DenseConjunctionBulkScorer}, which calls {@code BatchDocValuesRangeIterator.intoBitSet()}, + * dispatching to SIMD via {@code NumericDocValues.rangeIntoBitSet()} for MAYBE blocks. + * <li>Multi-field range: {@code DenseConjunctionBulkScorer} intersects all clauses via {@code + * intoBitSet()}, with YES blocks set directly and MAYBE blocks evaluated via {@code + * rangeIntoBitSet()}. + * </ul> + */ +public class TestSkipBlockRangeIteratorIntoBitSet extends LuceneTestCase { + + private static final int DOC_COUNT = 50_000; Review Comment: @sgup432 I do suggest having a "@Nightly" version of the doc count if we really need to have many to test this thing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
