vigyasharma commented on code in PR #15985: URL: https://github.com/apache/lucene/pull/15985#discussion_r3183222155
########## lucene/CHANGES.txt: ########## @@ -181,6 +181,8 @@ Bug Fixes * GITHUB#15939: Fix thread-safety issues with NFARunAutomaton. (Dimitris Rempapis) +* GITHUB#15831: Fixed a race condition in ReferenceManager.maybeRefresh() where refreshes could be missed if a new generation was flushed just before the refresh lock was released. (Vijay) Review Comment: Hi @vijaykriishna : the changes entry for each contribution lives in the release version it's targeted for. It is helpful then, in the release process, to go over the `CHANGES` file and see what is getting released. Typically, you'll find that the changes file has two upcoming release sections, one for the next major version (11.0.0 right now) and one for the next minor version (10.5.0). This change is backward compatible and doesn't break any APIs and can go in the next minor version release i.e. 10.5.0. So your changes entry will belong under the 10.5.0 header. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
