iprithv commented on PR #15983: URL: https://github.com/apache/lucene/pull/15983#issuecomment-4346167219
@mikemccand `getDidWork()` was the wrong check here. It can be false for skipped/up-to-date/not-selected test tasks even when nothing failed. I changed this to check `task.getState().getFailure() == null` instead [here](https://github.com/apache/lucene/pull/15997) On the count mismatch, I think `ProfileResults` is counting CPUTime samples that have a non-null stack trace, while `jfr summary` counts all `jdk.CPUTimeSample` events. The JFR summary has no `ExecutionSample` / `NativeMethodSample`, so this output should be coming from CPUTime. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
