gaobinlong opened a new pull request, #15995: URL: https://github.com/apache/lucene/pull/15995
### Description When testing the newly introduced TopGroupsCollectorManager in this [PR](https://github.com/apache/lucene/pull/15603), found that TopGroupsCollectorManager hardcoded 0 as the `withinGroupOffset` when calling TopGroups.merge(), causing pagination within groups to be silently ignored, this PR adds `withinGroupOffset` field and constructor parameter into TopGroupsCollectorManager, also modify the unit test to make it cover non-zero `withinGroupOffset` case. In addition, simplify the TopGroupsCollectorManager.reduce() method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
