uschindler commented on issue #15730: URL: https://github.com/apache/lucene/issues/15730#issuecomment-4313706993
I think we can do the changes, but we should do it without that tons of duplicated code. Basically the try...catch should be generalized and the code for saving and restoring the position should be done with a lambda or something. As you said it is not really performance critical (happens only very seldom), possibly never at all. It's fine. So I agree to maybe fix this for MemorySegmentIndexInput, but then other implementations in Lucene should also be reviewed that work in a similar way. I think ByteBuffersDirectory has similar problems and is having much smaller chunk sizes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
