sgup432 commented on PR #15558: URL: https://github.com/apache/lucene/pull/15558#issuecomment-4287816426
@msokolov Few things to note about this change is that methods like onQueryCache/eviction in this cache have been deprecated. The methods are around listening to unique queries eviction or caching activity for cache stats. But with this change we don't have a way to know that as we key structure has changed. Though we still support it for backward compatibility but users won't get accurate stats. We have introduced new methods for stats now. In addition, the cleanup has moved to a background thread, for that users need to pass a executor service or they can do manual cleanup. Otherwise by default, cleanups are disabled. IMO So taking it in 11.0 might make sense as we are disabling cache by default and users can integrate when they want it and take new changes. If you think the above changes are fine to be taken in 10.5, we can do that as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
