drempapis commented on code in PR #15961:
URL: https://github.com/apache/lucene/pull/15961#discussion_r3091655915
##########
lucene/highlighter/src/java/org/apache/lucene/search/uhighlight/MultiTermHighlighting.java:
##########
@@ -84,5 +85,11 @@ public void consumeTermsMatching(
Query query, String field, Supplier<ByteRunAutomaton> automaton) {
runAutomata.add(LabelledCharArrayMatcher.wrap(query.toString(),
automaton.get()));
}
+
Review Comment:
That's a good point. I updated the consumeTermsMatching signature applying
`Supplier<ByteRunnable>`.
Regarding the second part, I agree that using a `Predicate<BytesRef>` should
be handled in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
