Tim-Brooks opened a new pull request, #15960: URL: https://github.com/apache/lucene/pull/15960
The parent field (used for block indexing) was previously managed by DWPT: it created a ReservedField wrapper, injected the field into the last document's iterator via addParentField(), and relied on a delegating ReservedField class to guard the field name from external use. Move ownership of the parent field into IndexingChain, where field schemas and processing already live. The parent field and its PerField are created once in the IndexingChain constructor, and processDocument handles it directly in both passes when lastDocInBlock is true. Reserved field detection uses a simple identity check (pf == parentPf) instead of the ReservedField wrapper class. This removes ~90 lines of boilerplate (ReservedField, addParentField iterator, reserved boolean on PerField) and avoids per-document iterator allocation and redundant schema re-validation for the parent field. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
