rmuir commented on PR #15939: URL: https://github.com/apache/lucene/pull/15939#issuecomment-4214790693
> @rmuir The prototype for `RegexpQuery` LGTM. I've made only one update in `NFARunAutomaton`. The previous implementation had shared mutable state without proper synchronization, so concurrent access could corrupt internal state and lead to random failures. This update makes (or is intended to make) `NFARunAutomaton` safe for concurrent use. @drempapis thank you so much for tackling this! I'm gonna run the tests a few times and see if we can get them mostly stable. I don't think we need to achieve perfection to move forwards and merge these changes, but I also don't want to cause a flurry of build failures if there are easy fixes. Some of these tests are pretty tough. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
