drempapis commented on PR #15937: URL: https://github.com/apache/lucene/pull/15937#issuecomment-4196994787
Thanks @rmuir , this is a fair concern. My intent with the callback was to support callers that already control the determinization call site directly, not to immediately thread a new parameter through WildcardQuery, RegexpQuery, tokenizers, etc. That said, I agree with your point that for a stable Lucene API, if we introduce this as a public control, we should likely propagate it consistently through higher-level entry points (similar to how `determinizeWorkLimit` is exposed today). Would you prefer we move in that propagation direction, or do you have a different API shape in mind? I’m happy to adjust accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
