vsop-479 commented on PR #15823: URL: https://github.com/apache/lucene/pull/15823#issuecomment-4168635670
> I think there is a bit of backwards compatibility issue because the already existing Collection based version now behaves a bit different on exception. Oh, I missed this. > Here it is similar: If you hit an exception the difference is now that heap is sane afterwards, before it was not sane. So it is better afterwards. Anybody who tried to cleanup from it in the past would have made the heap sane, but doing that twice is not an issue. +1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
