Huaixinww opened a new pull request, #15908: URL: https://github.com/apache/lucene/pull/15908
This PR is a follow-up to https://github.com/apache/lucene/pull/15078 The previous change in #15078 intended to reduce the default value of SharedArenaMaxPermits from 1024 to 64 by updating RefCountedSharedArena.DEFAULT_MAX_PERMITS. However, the change did not take effect because of a magic number in the getSharedArenaMaxPermitsSysprop() method: ``` private static int getSharedArenaMaxPermitsSysprop() { int ret = 1024; // default value ``` This magic number effectively overrides the DEFAULT_MAX_PERMITS constant, making the intended change from the previous PR ineffective. This PR fixes the issue by replacing the magic number 1024 with the DEFAULT_MAX_PERMITS constant. This ensures that the default value is sourced from the constant as intended. If there are other considerations here, please let me know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
