sgup432 commented on code in PR #15818:
URL: https://github.com/apache/lucene/pull/15818#discussion_r2989246437
##########
lucene/core/src/java/org/apache/lucene/search/similarities/BM25Similarity.java:
##########
@@ -54,6 +58,21 @@ public BM25Similarity(float k1, float b, boolean
discountOverlaps) {
}
this.k1 = k1;
this.b = b;
+ this.k3 = k3;
Review Comment:
Added checks for nan/inf and I think it should be sufficient enough. Any
negative value will disable saturation, and 0 or any positive values are valid
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]