jaepil commented on PR #15827: URL: https://github.com/apache/lucene/pull/15827#issuecomment-4101379431
@benwtrent Thank you for the review! Good point -- the naming reflects two different layers: - Document matching: yes, this is a disjunction. It extends DisjunctionScorer and any matching sub-query contributes to the result. - Scoring model: "conjunction" refers to the probabilistic operation -- combining evidence via log-odds addition, which is the Bayesian mechanism for computing P(A AND B) under conditional independence. So the name describes what the scoring computes (probabilistic conjunction of evidence), not how documents are matched (which is indeed a disjunction). That said, I can see how this is confusing in Lucene's context where Conjunction/Disjunction have established meanings tied to document matching. Happy to rename if that helps -- something like `LogOddsFusionQuery`/`LogOddsFusionScorer` would avoid the ambiguity while staying descriptive of the hybrid search use case. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
