cortlepp commented on code in PR #15843:
URL: https://github.com/apache/lucene/pull/15843#discussion_r2965203768
##########
lucene/core/src/java/org/apache/lucene/store/PosixNativeAccess.java:
##########
@@ -79,14 +81,12 @@ static Optional<NativeAccess> getInstance() {
+ "pass the following on command line:
--enable-native-access=%s",
Optional.ofNullable(PosixNativeAccess.class.getModule().getName())
.orElse("ALL-UNNAMED")));
- } catch (RuntimeException | Error e) {
Review Comment:
> Can you explain why it may fail and lead to clinit problem and later
ClassDefNotFoundExceptions?
If one of these blocks is triggered, `PosixNativeAccess` will not be loaded.
If that is the case, any invocation of `NativeAccess::getInstance()` will fail
because it needs access to `PosixNativeAccess`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
