gsmiller commented on PR #15823: URL: https://github.com/apache/lucene/pull/15823#issuecomment-4083870463
I'm a bit uncomfortable with adding a "no shift" API to PQ. It has potential to be pretty trappy. Is there a better way to get at what you're trying to do? Maybe we could leverage `#addAll` from the DisjunctionMaxBulkScorer ctor? I get that we don't need the downHeap operation if everything is actually equal, but it doesn't seem particularly expensive? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
