sgup432 commented on PR #15821: URL: https://github.com/apache/lucene/pull/15821#issuecomment-4070287369
>It might be a much better idea to change the code more: >In the bulder create the list at end (immutable) instead of an array. This would spare multiple conversions from lists to arrays and back. > in the private constructor take the unmodifiable list. This makes sense to me, and it is a better way to go about it instead of just changing it in the constructor like this PR does. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
