tyronecai commented on PR #15775: URL: https://github.com/apache/lucene/pull/15775#issuecomment-3987587612
> Checks don't pass. Also, refining this class in microbenchmarks is not the same as running it in the wild - there is significant complexity if you add higher-tier code. I'd say that this may not be worth the increased code complexity. You'd need to try macro-benchmarks (luceneutil) and see if this shows any improvement, I don't think you'll see much there.检查未通过。此外，在微基准测试中优化这个类与在真实环境中运行是不同的——如果添加了更高层次的代码，复杂性会显著增加。我认为这种增加的代码复杂性并不值得。您需要尝试宏观基准测试（luceneutil），看看是否能看到任何改进，不过我觉得效果不会太明显。 Okay, I also think this change is a bit strange. > Checks don't pass. Also, refining this class in microbenchmarks is not the same as running it in the wild - there is significant complexity if you add higher-tier code. I'd say that this may not be worth the increased code complexity. You'd need to try macro-benchmarks (luceneutil) and see if this shows any improvement, I don't think you'll see much there. Okay, I also think this change is a bit strange. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
