mikemccand commented on PR #15472: URL: https://github.com/apache/lucene/pull/15472#issuecomment-3670439886
> > how does your PR here compare to that original PR? > > I looked at the original PR as a starting point, but found that there were several key changes in the upstream OpenSearch implementation that could be brought in. Merging those commits seemed unwieldy, so I opted to start from scratch by [checking out the codec](https://github.com/apache/lucene/pull/15472/commits/7843b82f6cdc1f3075a2ff5f489039f20c2c7c0a) into the sandbox. Then I fixed the build and style issues before making some changes to how the codec actually works to get more functional parity with Lucene's HNSW codecs. Specifically trying to get the extra KNN tests passing and moving towards the single-indexing-thread model as I mentioned above. Got it -- the upstream (OpenSearch jvector plugin Codec) changed a lot since @RKSPD's first PR. But then I wonder if we are missing anything that @RKSPD did the first time around? Or is this PR entirely a superset of how that first PR was using jVector? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
