dweiss commented on code in PR #15508:
URL: https://github.com/apache/lucene/pull/15508#discussion_r2625928791
##########
build.gradle:
##########
@@ -18,6 +18,7 @@
plugins {
id "base"
id "lucene.root-project.setup"
+ id "c"
Review Comment:
this can be moved to the project which actually uses the plugin (misc?).
##########
lucene/core/build.gradle:
##########
@@ -31,6 +31,14 @@ dependencies {
moduleTestImplementation project(':lucene:test-framework')
}
+test {
+ dependsOn ':lucene:misc:buildNative'
+ systemProperty(
+ "java.library.path",
+
project(":lucene:misc").layout.buildDirectory.get().asFile.absolutePath +
"/libs/dotProduct/shared"
+ )
+}
+
Review Comment:
All of these changes should be pulled into a single gradle java plugin that
handles the configuration across all the involved projects. If native libs are
not enabled, these changes shouldn't be applied at all. A single plugin will
make it easier to see the set of changes applied globally; currently they're
scattered around.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
