prudhvigodithi commented on PR #15490:
URL: https://github.com/apache/lucene/pull/15490#issuecomment-3633535810
> I don't think any of this needs to be static. Just make it non-static and
move it to the constructor of AssertingCodec?
Please correct me if i'm wrong looking at the code it has to be static as
during the call Codec.forName("Asserting"), we get the same cached instance
that was created during SPI loading and not a new one. This instance was
created before any test code runs and so needs static as the cached SPI
instance needs to read the suppression settings.
I have tried with a constructor and during my local tests not able to load
the `@SuppressAssertingFormats`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
