epotyom commented on PR #15458: URL: https://github.com/apache/lucene/pull/15458#issuecomment-3617935050
@benwtrent this change gives us significant enough performance boost, I think it is because BooleanWeight has optimizations for clauses which return `null` scorerSupplier https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/search/BooleanWeight.java#L293 But looks like it is bad for low memory scenarios, so I wonder if propagating `isLoaded` result from `#prefetch` https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/store/MemorySegmentIndexInput.java#L332 to TermStates to decide if we want to use lambda or call `termExistsSupplier.get()` right away could be the way? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
