prudhvigodithi commented on PR #15446:
URL: https://github.com/apache/lucene/pull/15446#issuecomment-3577244511

   > what are the benefits of using this against current main?
   
   Here are some important results 
https://github.com/apache/lucene/pull/15446#issuecomment-3577215055. I can 
clearly see this PR change helped to reduce the regression with 
`PointRangeQuery` when intra segment search is enabled, but still disabling 
intra segment search showed faster results. 
   
   I notice the following in heap profile with enabling intra segment and using 
this PR optimization when compared to baseline 
   
   #### Enabling intra segment and using this PR optimization
   ```
   28.10%        14122M        org.apache.lucene.util.FixedBitSet#<init>() 
[Inlined code]
   8.88%         4463M         
org.apache.lucene.util.DocIdSetBuilder$Buffer#<init>() [Inlined code]
   ```
   
   #### Baseline without intra segment
   ```
   12.55%        3412M         org.apache.lucene.util.FixedBitSet#<init>() 
[Inlined code]
   2.54%         689M          
org.apache.lucene.util.DocIdSetBuilder$Buffer#<init>() [Inlined code]
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to