blerer opened a new issue, #15452:
URL: https://github.com/apache/lucene/issues/15452

   ### Description
   
   `FilterIndexInput` and `FilterIndexOutput` do not always delegate calls to 
the instances that they decorate which can cause them to override the behavior 
of the instances they are delegating to.
   For example, it is possible in your own `IndexInput` implementation to 
override `readMapOfStrings` but if an instance of your classe is decorated by a 
`FilterIndexInput` instance when `readMapOfStrings` is called the logic that 
will be called is the one of DataInput.readMapOfStrings.
   This behavior is verified by the `TestFilterIndexInput.testOverrides` unit 
test.
   This approach seems error prone to me and go against the implementation of 
the methods like `readMapOfStrings`  that could have been made final if they 
should not have been overridden.
   
   Happy to provide a patch is that problem is recognize as such. :-) 
   
   ### Version and environment details
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to