rahulgoswami commented on PR #15431: URL: https://github.com/apache/lucene/pull/15431#issuecomment-3573864761
I think I agree with your solution here. Since certain tests are checking for N-2 version , might be prudent to not break that compatibility on a minor version. So I reverted the header check on SegmentInfos to VERSION_74. Looks like a lot of these N-2 tests were introduced in 9.10 in https://github.com/apache/lucene/pull/13046. I get it that we probably want to see if we can read such unsupported indexes with the supplied backward-codes, but the motivation behind that is still not super clear to me. Also, one could argue that if a default backward Lucene codec is not found on the class path, the probability of it being a too old index is much higher than just a missing backward-codecs.jar . So throwing a IndexFormatTooOldException in readCodec() should be acceptable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
