msfroh commented on PR #15383: URL: https://github.com/apache/lucene/pull/15383#issuecomment-3533814898
> Before I run the full benchmarks I guess I can quickly test the final DocIdSet's ramBytesUsed ? this should show reduction with partition aware DocIdSetBuilder. This doesn't need to be demonstrated by a test. It's obvious that if you have a segment with N docs and you split it into two partitions and allocate two arrays with N/2 bits each it will use half the memory of two arrays with N bits each. Nobody is disputing the reduction in heap usage. The question is whether the reduction in heap usage will have a measurable impact, which we can only see from benchmarks. Also, if we can reduce the number of tree traversals (i.e. only do one tree traversal per segment instead of per partition), then we would expect to see a performance benefit, since we're doing less work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
