benwtrent commented on code in PR #15415:
URL: https://github.com/apache/lucene/pull/15415#discussion_r2519567398
##########
lucene/core/src/java/org/apache/lucene/util/quantization/OptimizedScalarQuantizer.java:
##########
@@ -245,23 +245,22 @@ public QuantizationResult scalarQuantize(
* @param quantized the quantized byte vector to dequantize
* @param dequantized the output array to store dequantized float values
* @param bits the number of bits used for quantization
- * @param correctiveValues array containing [a, b, unused] where a=min,
b=max of quantization
- * range
+ * @param lowerCorrectiveValue min value of quantization range
+ * @param upperCorrectiveValue max value of quantization range
* @param centroid the centroid vector that was subtracted during
quantization
* @return the dequantized float array (same as dequantized parameter)
*/
public static float[] deQuantize(
byte[] quantized,
float[] dequantized,
byte bits,
- float[] correctiveValues,
Review Comment:
lets name these `lowerInterval` and `upperInterval`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
