gsmiller commented on PR #15303: URL: https://github.com/apache/lucene/pull/15303#issuecomment-3493743233
I like this change. With respect to the `deprecated` notice, it looks like these big endian var handles were added back in 2021 (#308) in a deprecated state. It seems OK to me to leverage it here for this use (we could always change this if we wanted to actually remove these BE var handles). In terms of impact, it looks like the only meaningful usage is of `subtract` from `BKDWriter`. So I wouldn't expect much performance impact (at least not in the query-centric benchmarking... and probably not really in a noticeable way while indexing)? Still seems like a nice, contained change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
