rmuir commented on code in PR #15395:
URL: https://github.com/apache/lucene/pull/15395#discussion_r2486358746
##########
build-tools/build-infra/src/main/java/org/apache/lucene/gradle/WrapperDownloader.java:
##########
@@ -209,7 +209,6 @@ public void run(Path destination) throws IOException,
NoSuchAlgorithmException {
}
}
- @SuppressForbidden(reason = "Valid use of thread.sleep.")
private static void sleep(long millis) throws InterruptedException {
Review Comment:
Yes, you are correct... I think honestly, this must happen only when a wrong
JDK version is used.
Battle story:
First thing I tried was to use an actual java 25 container: I set "image" in
the devcontainer.json, but it ignores it and used
`mcr.microsoft.com/devcontainers/universal` no matter what. This caused me a
lot of confusion, because I didn't expect it, and build failed with errors such
as "SuppressForbidden not found" rather than "wrong jdk version"
After removing the SuppressForbidden, I got error message that java 23 was
required :) After fixing that, I stopped fighting container image and just used
the "java extension" to request "latest". "latest" means java 21, but it is
better than java 11. After changing to request "25" explicitly, it finally
worked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
