msokolov commented on code in PR #14607:
URL: https://github.com/apache/lucene/pull/14607#discussion_r2469137961
##########
lucene/core/src/java/org/apache/lucene/index/SegmentInfos.java:
##########
@@ -402,11 +389,38 @@ private static void parseSegmentInfos(
}
long totalDocs = 0;
+
for (int seg = 0; seg < numSegments; seg++) {
String segName = input.readString();
byte[] segmentID = new byte[StringHelper.ID_LENGTH];
input.readBytes(segmentID, 0, segmentID.length);
- Codec codec = readCodec(input);
+ Codec codec = null;
+ try {
+ codec = readCodec(input);
Review Comment:
readCodec is private in this class so we're free to change it. Let's make it
throw `IndexFormatTooOldException` directly; then there is no need to catch and
rethrow.
Also -- it is still possible that the user actually *did* forget to load
lucene-backward-codecs.jar and the version of the index they are trying to load
actually *is* a supported one.
I think what we need to do is to add an explicit check on the index version
somewhere so we can distinguish between a supported codec that failed to load
and an unsupported (too old) codec.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
