uschindler commented on PR #15237: URL: https://github.com/apache/lucene/pull/15237#issuecomment-3339049777
Just as comment: I tried to rewrite the serialization and desericalization with DataOutput. For the bigram dict with ZigZag encoding its one megabyte smaller (but JAR file size did not change much), but the main dictionary is hard to serialize easily as we have no methods to save sparse multidimensional char/int arrays. So I kept the serialization code for now, we may look into the complete rewrite later. For now the code is 100% safe due to the serialization filter. I see no reason to change the data format for now, unless we can start from scratch with the original dictionary source code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
