jainankitk commented on PR #14413: URL: https://github.com/apache/lucene/pull/14413#issuecomment-3404133478
Thanks @dungba88 for trying this out. > I don't see its Thread object is being used anywhere, can it be removed? The `Thread` object is used for maintaining the association (as @msokolov called out) during aggregation of segment level Profiler Result. I was not exactly sure what all fields from `Thread` might be needed/make sense for serialization, so kept `Thread` itself in `AggregatedQueryLeafProfilerResult`. I am wondering if it makes sense to add `@JsonIgnore` / `transient` to not serialize `Thread` (and avoid exception/errors) and instead have limited view of `Thread`, say `SerializableThread` containing all the properties that we want to have in the serialization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
