linyunanit commented on code in PR #15332:
URL: https://github.com/apache/lucene/pull/15332#discussion_r2425795362
##########
lucene/core/src/test/org/apache/lucene/search/TestPhraseQuery.java:
##########
@@ -743,6 +743,20 @@ public void testBackwardPositions() throws Exception {
});
}
+ public void testPhraseQueryTermLimit() throws Exception {
+ PhraseQuery.Builder builder = new PhraseQuery.Builder();
+ int termLimit = 1000;
Review Comment:
Good points, @dweiss! I've made the following changes based on your feedback:
- Reduced `termLimit` from 1000 to 5 to make the test more lightweight
- Changed the position logic to use `0..termLimit-1` and check for failure
at position `termLimit`
This does make the test more intuitive. Thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
