kaivalnp commented on PR #15272: URL: https://github.com/apache/lucene/pull/15272#issuecomment-3357992746
We use the [same underlying function](https://github.com/apache/lucene/blob/cd88a97a63a97dc857d692ec3eb73b229bb5f372/lucene/core/src/java25/org/apache/lucene/internal/vectorization/PanamaVectorUtilSupport.java#L387) for a [variety of combinations](https://github.com/apache/lucene/blob/cd88a97a63a97dc857d692ec3eb73b229bb5f372/lucene/core/src/java25/org/apache/lucene/internal/vectorization/PanamaVectorUtilSupport.java#L361-L385) of on and off-heap vectors -- which may lead to its call site being polluted, and compiled functions being sub-optimal To demonstrate this, I added some type pollution to [`VectorScorerBenchmark`](https://github.com/apache/lucene/blob/main/lucene/benchmark-jmh/src/java/org/apache/lucene/benchmark/jmh/VectorScorerBenchmark.java) Benchmark without pollution: ``` Benchmark (size) Mode Cnt Score Error Units VectorScorerBenchmark.binaryDotProductMemSeg 1024 thrpt 15 7.543 ± 0.062 ops/us ``` Benchmark with pollution: ``` Benchmark (size) Mode Cnt Score Error Units VectorScorerBenchmark.binaryDotProductMemSeg 1024 thrpt 15 6.327 ± 0.057 ops/us ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
