kaivalnp commented on code in PR #15238:
URL: https://github.com/apache/lucene/pull/15238#discussion_r2383499099
##########
build-tools/build-infra/src/main/java/org/apache/lucene/gradle/plugins/java/JavaProjectConventionsPlugin.java:
##########
@@ -48,8 +48,8 @@ private void applyJavaPlugins(Project project) {
plugins.apply(TestsAndRandomizationPlugin.class);
plugins.apply(TestsBeastingPlugin.class);
plugins.apply(TestsSummaryPlugin.class);
- plugins.apply(ApplyForbiddenApisPlugin.class);
- plugins.apply(EcjLintPlugin.class);
+ // TODO plugins.apply(ApplyForbiddenApisPlugin.class);
+ // TODO plugins.apply(EcjLintPlugin.class);
Review Comment:
This was failing with:
```
Caused by: org.gradle.api.GradleException: ecj linter failed:
source level should be in '1.8','9'...'24' (or '8.0'..'24.0'): 25
at
org.apache.lucene.gradle.plugins.java.EcjLintPlugin.lambda$configureEcjTask$0(EcjLintPlugin.java:204)
at
org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:820)
at
org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:793)
at
org.gradle.api.internal.tasks.execution.TaskExecution$3.run(TaskExecution.java:252)
...
```
Perhaps
[ecj](https://github.com/apache/lucene/blob/79cb40f6adae50074e6fe2ff5235aaf43f5dce7f/gradle/libs.versions.toml#L12)
does not support Java 25 yet?
Although we're already on the latest version:
https://mvnrepository.com/artifact/org.eclipse.jdt/ecj
##########
gradle/wrapper/gradle-wrapper.jar.sha256:
##########
@@ -1 +1 @@
-7d3a4ac4de1c32b59bc6a4eb8ecb8e612ccd0cf1ae1e99f66902da64df296172
*gradle-wrapper.jar
+76805e32c009c0cf0dd5d206bddc9fb22ea42e84db904b764f3047de095493f3
*gradle-wrapper.jar
Review Comment:
Checksum: https://gradle.org/release-checksums/#9.1.0
##########
build-tools/build-infra/src/main/java/org/apache/lucene/gradle/plugins/java/JavaProjectConventionsPlugin.java:
##########
@@ -48,8 +48,8 @@ private void applyJavaPlugins(Project project) {
plugins.apply(TestsAndRandomizationPlugin.class);
plugins.apply(TestsBeastingPlugin.class);
plugins.apply(TestsSummaryPlugin.class);
- plugins.apply(ApplyForbiddenApisPlugin.class);
- plugins.apply(EcjLintPlugin.class);
+ // TODO plugins.apply(ApplyForbiddenApisPlugin.class);
Review Comment:
This was failing with:
```
Caused by: java.io.FileNotFoundException: Bundled signatures resource not
found: jdk-unsafe-25
at
de.thetaphi.forbiddenapis.Signatures.addBundledSignatures(Signatures.java:295)
at
de.thetaphi.forbiddenapis.Signatures.addBundledSignatures(Signatures.java:345)
at
de.thetaphi.forbiddenapis.Checker.addBundledSignatures(Checker.java:335)
at
de.thetaphi.forbiddenapis.gradle.CheckForbiddenApis.checkForbidden(CheckForbiddenApis.java:617)
... 125 more
```
Java 25 signatures are missing in
https://github.com/policeman-tools/forbidden-apis/tree/main/src/main/resources/de/thetaphi/forbiddenapis/signatures
cc @uschindler
##########
settings.gradle:
##########
@@ -89,9 +89,5 @@ include "lucene:spatial-test-fixtures"
include "lucene:suggest"
include "lucene:test-framework"
-include "lucene:build-tools:missing-doclet"
-include "lucene:build-tools:build-infra-shadow"
-
-// tweak the physical path for build-tools.
-project(":lucene:build-tools:missing-doclet").projectDir =
file("build-tools/missing-doclet")
-project(":lucene:build-tools:build-infra-shadow").projectDir =
file("build-tools/build-infra-shadow")
+include "build-tools:missing-doclet"
+include "build-tools:build-infra-shadow"
Review Comment:
Renamed `:lucene:build-tools` -> `:build-tools` (see
https://docs.gradle.org/8.14.2/userguide/upgrading_version_8.html#deprecated_missing_project_directory)
##########
gradle/documentation/render-javadoc/java-25/element-list:
##########
@@ -95,6 +95,7 @@ javax.print
javax.print.attribute
javax.print.attribute.standard
javax.print.event
+javax.sound
Review Comment:
This file was copied from
https://docs.oracle.com/en/java/javase/25/docs/api/element-list
##########
build-tools/build-infra/src/main/groovy/lucene.regenerate.icu.gradle:
##########
@@ -94,8 +95,9 @@ configure(project(":lucene:analysis:icu")) {
doFirst {
// all these steps must be done sequentially: it's a pipeline resulting
in utr30.nrm
- project.javaexec {
- main = "org.apache.lucene.analysis.icu.GenerateUTR30DataFiles"
+ def execOps = objects.newInstance(ExecOperationsProvider).execOperations
+ execOps.javaexec {
+ mainClass = "org.apache.lucene.analysis.icu.GenerateUTR30DataFiles"
Review Comment:
`project.javaexec` was removed
(https://docs.gradle.org/current/userguide/upgrading_version_8.html#deprecated_project_exec),
using the
[`ExecOperationsProvider`](https://github.com/apache/lucene/blob/79cb40f6adae50074e6fe2ff5235aaf43f5dce7f/lucene/analysis/common/build.gradle#L58-L63)
approach instead
##########
lucene/core/src/generated/jdk/jdk25-api.jar:
##########
Review Comment:
Generated by:
```
./gradlew regenerate
```
##########
versions.lock:
##########
Review Comment:
These changes were generated by:
```
./gradlew writeLocks
```
I'm not sure if they need to be in this PR..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
