kaivalnp commented on code in PR #14863:
URL: https://github.com/apache/lucene/pull/14863#discussion_r2337663908
##########
lucene/core/src/test/org/apache/lucene/internal/vectorization/TestVectorUtilSupport.java:
##########
@@ -107,11 +107,11 @@ public void testInt4DotProduct() {
b[i] = (byte) random().nextInt(16);
}
- assertIntReturningProviders(p -> p.int4DotProduct(a, false, pack(b),
true));
Review Comment:
cosine does not have a separate function in `PanamaVectorUtilSupport` (it
re-uses dot product) -- but I've added tests for square distance (and their
packed versions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]