gaobinlong commented on PR #15167: URL: https://github.com/apache/lucene/pull/15167#issuecomment-3273405955
> Should this use the return value of `GroupSelector#advanceTo(int)` (returns an enum with `SKIP` or `ACCEPT`) instead of checking for a `null` value? The collector currently ignores it, but it looks like the intended way of skipping a hit. That doesn't work, ValueSourceGroupSelector.advanceTo() always return ACCEPT: https://github.com/apache/lucene/blob/main/lucene/grouping/src/java/org/apache/lucene/search/grouping/ValueSourceGroupSelector.java#L69 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
